Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Validate IPs in Access Control #30299

Closed
kiler129 opened this Issue Feb 18, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@kiler129
Copy link
Contributor

kiler129 commented Feb 18, 2019

Description
The feature to use access_control for IP validation is very convenient. However it doesn't validate IPs, which may lead to confusing debugging scenarios (e.g. #30298)

Example
Putting anything that it's not an IP or a subnet mask should result in an exception.

@chalasr

This comment has been minimized.

Copy link
Member

chalasr commented Feb 19, 2019

👍 PR welcome

@kiler129

This comment has been minimized.

Copy link
Contributor Author

kiler129 commented Feb 19, 2019

I will happily deliver a PR :)

@javiereguiluz javiereguiluz added this to the next milestone Feb 19, 2019

@chalasr chalasr closed this Mar 7, 2019

chalasr added a commit that referenced this issue Mar 7, 2019

feature #30385 [SecurityBundle] Validate the IPs configured in access…
…_control (javiereguiluz)

This PR was squashed before being merged into the 4.3-dev branch (closes #30385).

Discussion
----------

[SecurityBundle] Validate the IPs configured in access_control

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30299
| License       | MIT
| Doc PR        | -

Commits
-------

857ac95 [SecurityBundle] Validate the IPs configured in access_control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.