Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] broken terminal after running tests #30861

Closed
nicolas-grekas opened this Issue Apr 4, 2019 · 2 comments

Comments

Projects
None yet
6 participants
@nicolas-grekas
Copy link
Member

commented Apr 4, 2019

On 3.4, 4.2, master:

When I run the tests of the Console component, my terminal ends up being broken.
Running this is enough to reproduce:
./phpunit src/Symfony/Component/Console/ --filter testCommandWithQuestionsButNoInputs

If I revert #30271, the issue is gone.
ping @chalasr if you have any idea why

@chalasr

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Test green on my side (OSX), same on travis/appveyor.
Looks like a platform issue, is there anything special in your setup? e.g. non stable php version?

@Simperfit

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

I'm taking this one for the euchackaton

@fabpot fabpot closed this Apr 6, 2019

fabpot added a commit that referenced this issue Apr 6, 2019

bug #30883 [Console] Fix stty not reset when aborting in QuestionHelp…
…er::autocomplete() (Simperfit)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix stty not reset when aborting in QuestionHelper::autocomplete()

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30861   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

f54389b bugfix: the terminal state was wrong and not reseted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.