Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotPwnedValidator should convert passwords to UTF-8 #30870

Closed
nicolas-grekas opened this Issue Apr 5, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Apr 5, 2019

Before computing the hashes, we must ensure the passwords are encoded/converted in UTF-8, as expected by the remote DB/API.

@xabbuh xabbuh added the Validator label Apr 5, 2019

@tgalopin

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Working on this as part of the #eu-fossa.

@fabpot fabpot closed this Apr 6, 2019

fabpot added a commit that referenced this issue Apr 6, 2019

feature #30898 [Validator] Wire NotCompromisedPassword in FrameworkBu…
…ndle and handle non UTF-8 password (tgalopin)

This PR was squashed before being merged into the 4.3-dev branch (closes #30898).

Discussion
----------

[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30870
| License       | MIT
| Doc PR        | -

Live from #eu-fossa

Fix #30870

Commits
-------

8ac712b [Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.