Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] about add cache size limit in IpUtils #31388

Open
phpor opened this issue May 6, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@phpor
Copy link

commented May 6, 2019

Description
In src/Symfony/Component/HttpFoundation/IpUtils.php , static variables are used to optimize the performance of the cache, but without limiting the size of the cache, the size of the cache can become large over time, will it would be better to adding cache size limits?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 21, 2019

will it would be better to adding cache size limits?

only if it provides something useful in practice. PR welcome if you think so (ie have a use case ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.