Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] DeprecationErrorHandler should read from $_SERVER/ENV #31857

Open
nicolas-grekas opened this issue Jun 4, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 4, 2019

Right now, it reads SYMFONY_DEPRECATIONS_HELPER using only getenv(), but this will soon become incompatible with Dotenv, since we switcher it to not use putenv() by default in new projects.

(note that I wouldn't change reading the other env vars in the class - only SYMFONY_DEPRECATIONS_HELPER makes sense for Dotenv)

/cc @greg0ire if you want to give it a try :)

@greg0ire

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Added to my todo list :)

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 8, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857

greg0ire added a commit to greg0ire/symfony that referenced this issue Jun 9, 2019

Read environment variable from superglobals
The Dotenv component has recently been switched to using superglobals
instead of putenv(). Let us support both and give priority to
superglobals.

Closes symfony#31857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.