Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] "auto" mode for option "buffer" #31883

Open
nicolas-grekas opened this issue Jun 5, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 5, 2019

the "buffer" option is required to allow accessing the content several times, but it should really be turned to false when downloading large files. We discussed with @joelwurtz about an "auto" mode, which could be the default one, and which would look at the content-type of the response to auto-enable buffering for some content types only. If anyone wants to take that task.

@nicolas-grekas nicolas-grekas referenced this issue Jun 5, 2019

Closed

[HttpClient] Next steps #30502

18 of 18 tasks complete
@rjwebdev

This comment has been minimized.

Copy link

commented Jun 12, 2019

Would like to give this one a try.

Are we going to decide the content types now for which the buffer should be enabled automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.