Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] replace return-type annotations by real type declarations on final classes #31981

Open
nicolas-grekas opened this issue Jun 10, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Jun 10, 2019

For master only, PR welcome.

@nicolas-grekas nicolas-grekas changed the title [5.0] replace return type annotation by real declaration on final classes [5.0] replace return-type annotations by real type declarations on final classes Jun 10, 2019

@dFayet

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

I would be glad to work on this, except if you think this task is more for a person with deep knowledge of the Sf code.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Please give it a try, we're here to help!

@dFayet

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

👍
Just to be sure, do we consider also the @final classes as final?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Yes!

@dFayet dFayet referenced this issue Jun 11, 2019

Open

[5.0] Add return types in final classes #31996

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.