Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wire Traceable Event Dispatcher in CLI #32422

Open
lyrixx opened this issue Jul 8, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@lyrixx
Copy link
Member

commented Jul 8, 2019

The TraceableEventDispatcher stores some informations for the
profiler. But in CLI it does not make sens, since the tooling does not
exist. I have already fixed such issue for monolog in #30339. I think we
should do the same for the TraceableEventDispatcher.

(I opened this discussion to keep a trace of a discussion in #32421)

@dmaicher

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

I actually got used to the fact that in dev environment lots of memory is used 🙈
So I usually execute longer running commands with --no-debug locally to avoid this.

When removing the TraceableEventDispatcher for CLI: Could there be an impact on this?
https://symfony.com/doc/current/testing/profiling.html

There is a data collector for events: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.