Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Do not perform deep merging #32953

Open
lyrixx opened this issue Aug 5, 2019 · 2 comments

Comments

@lyrixx
Copy link
Member

commented Aug 5, 2019

Description
I followed the doc to send email async.
It works well, but I don't want to add an extra consumer in test.
So in my config_test.yml I did that:

framework:
    messenger:
        routing:
            'Symfony\Component\Mailer\Messenger\SendEmailMessage': sync # instead of rabbitmq (called async in the doc)

But this is the resolved configuration:

routing:
    Symfony\Component\Mailer\Messenger\SendEmailMessage:
        senders:
            - rabbitmq
            - sync

IMHO, We should get only sync without rabbitmq

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

We should never deep-merge a config. If that's the case, it's a bug that should be fixed.

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

We almost already perform a deep-merge on configuration... We could not fix every places where configuration is an array as it will be a BC break I think.
Since the this composant is experimental in 4.3, can we safely avoid deep-merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.