Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] WebDebugToolbar collector for normalize/denormalize actions inside the serializer #39102

Closed
Basster opened this issue Nov 17, 2020 · 6 comments
Closed

[RFC] WebDebugToolbar collector for normalize/denormalize actions inside the serializer #39102

Basster opened this issue Nov 17, 2020 · 6 comments
Labels
Feature RFC RFC = Request For Comments (proposals about features that you want to be discussed) Serializer Stalled

Comments

@Basster
Copy link
Contributor

Basster commented Nov 17, 2020 •
edited

Description
To shed light on which Normalizers and Denormalizers have been used during Serialization/Deserialization, a WebDebugToolbar Panel might come in handy.

Example
Therefore I've created a small of PoC to showcase a possible solution (in Userland for now). I tried to described, how I've implemented it on the README.

https://github.com/Basster/Symfony-Serializer-Collector-PoC

#SymfonyHackday
@carsonbot carsonbot added the RFC RFC = Request For Comments (proposals about features that you want to be discussed) label Nov 17, 2020
@ro0NL
Copy link
Contributor

ro0NL commented Nov 18, 2020

#34228 :) let's try again

@Basster
Copy link
Contributor Author

Basster commented Nov 19, 2020

I've planned to migrate my PoC to a symfony PR this weekend. 🤞

@Basster
Copy link
Contributor Author

Basster commented Dec 3, 2020

I've planned to migrate my PoC to a symfony PR this weekend.

Okay, SymfonyWorld Hackday! ;)

@Basster Basster mentioned this issue Dec 5, 2020
Closed
5 tasks
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: thank you fabbot.
b2e2c86
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: thank you again fabbot.
05baa14
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: register the SerializerDebugPass and configured decora…
03d86f2 
…tor and data_collector for the container.
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: handle cachable normalizers as well.
b94c19c 
* and some code improvements.
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: fabbot again.
781a6cf
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: fabbot again and again.
0a7a83e
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: only run SerializerDebugPass when serializer is present.
a432b3d
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: added debug.normalizer tag to UnusedTagsPass.
eb0b1d6
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: c'mon fabbot...
7fd3171
Basster added a commit to Basster/symfony that referenced this issue Dec 5, 2020
@Basster
symfony#39102: register configuration on kernel.debug and use correct…
21c4d46 
… icon on serializer.html.twig.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: fix code style suggestions and suggested changes, first.
cba66e8
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: implement __call on AbstractTraceableNormalizer, to ke…
e31bd8b 
…ep custom methods on custom normalizers working, which are not part of the interface.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: avoid storing huge (de)serializing objects/strings in …
cfe328a 
…memory by replacing too large source-objects/results as replacement (LargeContent).
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: thank you fabbot.
19a4e9b
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: created TraceableSerializer and some value objects aro…
88e18ce 
…und it.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: migrated all the collector stuff from my PoC.
810e8b9
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: thank you fabbot.
4687873
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: thank you again fabbot.
dc5aa15
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: register the SerializerDebugPass and configured decora…
662571f 
…tor and data_collector for the container.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: handle cachable normalizers as well.
e716550 
* and some code improvements.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: fabbot again.
caee73d
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: fabbot again and again.
b9f64a6
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: only run SerializerDebugPass when serializer is present.
35d36c6
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: register configuration on kernel.debug and use correct…
378918a 
… icon on serializer.html.twig.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: fix code style suggestions and suggested changes, first.
1904167
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: implement __call on AbstractTraceableNormalizer, to ke…
488ac9a 
…ep custom methods on custom normalizers working, which are not part of the interface.
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: avoid storing huge (de)serializing objects/strings in …
9524c3f 
…memory by replacing too large source-objects/results as replacement (LargeContent).
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: thank you fabbot.
fd5f1e8
Basster added a commit to Basster/symfony that referenced this issue Dec 21, 2020
@Basster
symfony#39102: register missing services/aliases for SerializerDebugP…
dae8641 
…assTest.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: created TraceableSerializer and some value objects aro…
1c730b9 
…und it.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: migrated all the collector stuff from my PoC.
27ce406
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: thank you fabbot.
c9e2961
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: thank you again fabbot.
b896d64
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: register the SerializerDebugPass and configured decora…
7368cfb 
…tor and data_collector for the container.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: handle cachable normalizers as well.
a9ab284 
* and some code improvements.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: fabbot again.
52ed5d0
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: fabbot again and again.
e5afaff
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: only run SerializerDebugPass when serializer is present.
532235c
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: added debug.normalizer tag to UnusedTagsPass.
d7539d4
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: c'mon fabbot...
92e49b1
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: register configuration on kernel.debug and use correct…
9038316 
… icon on serializer.html.twig.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: fix code style suggestions and suggested changes, first.
c9c453e
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: implement __call on AbstractTraceableNormalizer, to ke…
0c5a2d8 
…ep custom methods on custom normalizers working, which are not part of the interface.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: avoid storing huge (de)serializing objects/strings in …
2c815cc 
…memory by replacing too large source-objects/results as replacement (LargeContent).
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: thank you fabbot.
6992af5
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: register missing services/aliases for SerializerDebugP…
f861ffe 
…assTest.
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: fixed new fabbot issues.
6de10f0
Basster added a commit to Basster/symfony that referenced this issue Mar 6, 2021
@Basster
symfony#39102: another fabbot fix.
18b55e6
@carsonbot
Copy link

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

@carsonbot
Copy link

Hello? This issue is about to be closed if nobody replies.

@carsonbot
Copy link

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature RFC RFC = Request For Comments (proposals about features that you want to be discussed) Serializer Stalled
Projects
None yet
Milestone
No milestone
4 participants
@ro0NL @Basster @derrabus @carsonbot