Bundle Translations Overrides should be in app/Resources/BundleName/translations #4018

Closed
fabpot opened this Issue Apr 20, 2012 · 1 comment

Projects

None yet

2 participants

@fabpot
Symfony member

see symfony/symfony-standard#161 for the original ticket:

"
Start with an example.

Let's say I am using SonataAdminBundle. It would seem appropriate that if I wanted to override that bundles translations those translations would be in app/Resources/SonataAdminBundle/translations similar to if I want to override the views of that bundle they reside in app/Resources/SonataAdminBundle/views.

This is not the case and in my opinion seems the more logical approach. Otherwise we will end up with hundreds of overriding translations for each language in the same directory. At least the option should be there to include the translations within the bundle override directory. So it could find overrides in app/Resources/BundleName/translations, or app/translations/someRandomBundle.en.xml/yml/php

Hopefully that makes sense and it makes it in time for 1.0 final which is today!!!

Please consider this. It makes sense.

Thanks.
"

@vicb

working on this one

@vicb vicb added a commit that closed this issue Apr 20, 2012
@vicb vicb [FrameworkBundle] Look for translations in %kernel.root_dir%/Resource…
…s/%bundle%/translations (fix #4018)
3937561
@vicb vicb closed this in 3937561 Apr 20, 2012
@homer6 homer6 pushed a commit to homer6/symfony that referenced this issue Apr 20, 2012
@fabpot fabpot merged branch vicb/translation/override (PR #4030)
Commits
-------

3937561 [FrameworkBundle] Look for translations in %kernel.root_dir%/Resources/%bundle%/translations (fix #4018)

Discussion
----------

[FrameworkBundle] Look for translations in %kernel.root_dir%/Resources/%...

...bundle%/translations (fix #4018)

I will submit a PR to the docs.
76a42c8
@mmucklo mmucklo pushed a commit that referenced this issue May 23, 2013
@vicb vicb [FrameworkBundle] Look for translations in %kernel.root_dir%/Resource…
…s/%bundle%/translations (fix #4018)
7ab532c
@mmucklo mmucklo pushed a commit that referenced this issue May 23, 2013
@fabpot fabpot merged branch vicb/translation/override (PR #4030)
Commits
-------

3937561 [FrameworkBundle] Look for translations in %kernel.root_dir%/Resources/%bundle%/translations (fix #4018)

Discussion
----------

[FrameworkBundle] Look for translations in %kernel.root_dir%/Resources/%...

...bundle%/translations (fix #4018)

I will submit a PR to the docs.
dc26d13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment