Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Specify sensitive query parameters #50182

Closed
ro0NL opened this issue Apr 28, 2023 · 1 comment
Closed

[HttpClient] Specify sensitive query parameters #50182

ro0NL opened this issue Apr 28, 2023 · 1 comment

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Apr 28, 2023

Description

Currently HttpClient logs the full request URL, including any senstive query parameters.

It be nice if we can specify the list of senstive query params, so they can be excluded in the logs:

07:22:11 INFO      [app] Request: "GET https://httpstat.us/200?sensitive"

See also #50168

Using HTTPlug we achieved this by specifying the logger plugin before the query plugin:

It is important to note that the order of plugins matters. During the request, plugins are executed in the order they have been specified in the constructor, from first to last (https://docs.php-http.org/en/latest/plugins/introduction.html?highlight=order#how-it-works)

Example

No response

@ro0NL ro0NL changed the title [HttpClient] Specify senstive query parameters [HttpClient] Specify sensitive query parameters Apr 28, 2023
@ro0NL
Copy link
Contributor Author

ro0NL commented May 1, 2023

don't persist the http_client channel 🤷

@ro0NL ro0NL closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants