[HttpFoundation] Request path can be wrong #6634

Closed
Tobion opened this Issue Jan 9, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Member

Tobion commented Jan 9, 2013

There is a problem with the path info in the Request class.

Given a request to http://localhost/symfony-standard/app_dev.php, the info in the Request are as follows:
Request::getBaseUrl() returns /symfony-standard/app_dev.php (correct)
Request::getPathInfo() returns / which is wrong because it must be empty ``.

The reason is that Request::getBaseUrl() . Request::getPathInfo() must represent the real request path. Since it is lying about the real path, #3958 generates the incorrect relative path based on the wrong info.

So there is a problem when the path info should be empty but never is (it defaults to /).
I think it's this commit that should be reverted: 62d09b8

ping @fabpot

Contributor

cmfcmf commented Jun 26, 2014

Could this be assigned to a milestone? I think an error in the Request class is quite important.

Member

Tobion commented Oct 8, 2014

@fabpot would you accept a PR that changes this back? Users of the Request class have to be aware that the pathinfo can be empty ('') when using a script in the path. The only other solution I see is to introduce a new method in the Request class with the corrected behavior and leave the current method as-is. Then we can dump the requirement in the Routing component for instance and use the new method. This would avoid a BC break but make the request class even more uglier than it already is.

@Tobion Tobion closed this Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment