[Console] Clean the unit tests #6935

Closed
vicb opened this Issue Feb 1, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

vicb commented Feb 1, 2013

Each of the unit test methods should be splitted in smaller blocks, see InputOptionTest for a bad example.

Member

jakzal commented Feb 1, 2013

I'll pick it up. @vicb I guess it should be done in 2.1?

Contributor

vicb commented Feb 1, 2013

master (as not a bug fix)

Contributor

vicb commented Feb 1, 2013

thanks... but please wait one day, I am fixing them before :)

Contributor

vicb commented Feb 1, 2013

well will be for next beginning of next week, pending a reply for fabpot. Feel free to go ahead before if you wish.

fabpot added a commit that referenced this issue Apr 9, 2013

merged branch jakzal/console-tests-cleanup (PR #6989)
This PR was merged into the master branch.

Discussion
----------

[Console] Cleaned up the unit tests.

Cleaned up some unit tests in the Console component as suggested in #6935. I didn't fully cleanup the Application tests to not to delay this PR. I might do it later as a separate one.

| Q              | A                                        |
|--------------|--------------------------------|
| Bug fix?          | no |
|New feature? | no |
|BC breaks?    | no |
|Deprecations? |	no |
|Tests pass? | yes |
|Fixed tickets | #6935 |
|License | MIT |
|Doc PR | n/a |

Commits
-------

5ca04b0 [Console] Cleaned up the unit tests.

@fabpot fabpot closed this Apr 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment