[FrameworkBundle] Enable possibility to run PHP bultin server in production env #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ('prod' === $env) { | ||
| $output->writeln( | ||
| '<error>Running PHP bultin server in production environment is NOT secure!</error>' |
|
@stof corrected thx |
|
|
||
| if ('prod' === $env) { | ||
| $output->writeln( | ||
| '<error>Running PHP built-in server in production environment is NOT secure!</error>' |
There was a problem hiding this comment.
Can you put everything on the same line? Also, it's not just about it being not secure, so I think something like "Running the PHP built-in server in a production environment is NOT recommended" would be better.
|
@fabpot corrected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the referenced ticket for discussion;