New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the TextAreaFormField to be used with valid/invalid HTML #10140

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dawehner
Contributor

dawehner commented Jan 26, 2014

The TextAreaFormField previously used saveXML to get a representation of the child nodes of an textarea.
This works pretty fine on simple text is causes issues in case you have broken HTML, as saveXML
will potentially also break encoding/change the structure.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jan 26, 2014

Member

Thank you @dawehner.

Member

fabpot commented Jan 26, 2014

Thank you @dawehner.

fabpot added a commit that referenced this pull request Jan 26, 2014

bug #10140 allow the TextAreaFormField to be used with valid/invalid …
…HTML (dawehner)

This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10140).

Discussion
----------

allow the TextAreaFormField to be used with valid/invalid HTML

The TextAreaFormField previously used saveXML to get a representation of the child nodes of an textarea.
This works pretty fine on simple text is causes issues in case you have broken HTML, as saveXML
will potentially also break encoding/change the structure.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT

Commits
-------

157a9de allow the TextAreaFormField to be used with valid/invalid HTML

@fabpot fabpot closed this Jan 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment