[Finder] () is also a valid delimiter #10299

Merged
merged 1 commit into from Feb 20, 2014

Conversation

Projects
None yet
2 participants
Member

wouterj commented Feb 20, 2014

The Regex class should also accept () as delimiters, as they are valid PREG delimiters: http://3v4l.org/D8v54

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

fabpot added a commit that referenced this pull request Feb 20, 2014

bug #10299 [Finder] () is also a valid delimiter (WouterJ)
This PR was merged into the 2.3 branch.

Discussion
----------

[Finder] () is also a valid delimiter

The `Regex` class should also accept `()` as delimiters, as they are valid PREG delimiters: http://3v4l.org/D8v54

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

b7519c7 () is also a valid delimiter

@fabpot fabpot merged commit b7519c7 into symfony:2.3 Feb 20, 2014

1 check passed

default Success: Travis, fabbot
Details

@wouterj wouterj deleted the wouterj:patch-5 branch Feb 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment