Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templating] PhpEngine should propagate charset to its helpers #10670

Merged
merged 1 commit into from Apr 10, 2014

Conversation

Projects
None yet
3 participants
@stloyd
Copy link
Contributor

commented Apr 9, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #10666
License MIT
@@ -368,6 +371,10 @@ public function escape($value, $context = 'html')
public function setCharset($charset)
{
$this->charset = $charset;
foreach ($this->helpers as $helper) {

This comment has been minimized.

Copy link
@staabm

staabm Apr 9, 2014

Contributor

What about helpers added after the charset has been set?

This comment has been minimized.

Copy link
@stloyd

stloyd Apr 9, 2014

Author Contributor

It's already covered by set() method.

This comment has been minimized.

Copy link
@stloyd

stloyd Apr 9, 2014

Author Contributor

@staabm The problem is described better in related issue, as well as in extended test.

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 10, 2014

Thank you @stloyd.

fabpot added a commit that referenced this pull request Apr 10, 2014

bug #10670 [Templating] PhpEngine should propagate charset to its hel…
…pers (stloyd)

This PR was merged into the 2.3 branch.

Discussion
----------

[Templating] PhpEngine should propagate charset to its helpers

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10666
| License       | MIT

Commits
-------

ed9e48b [Templating] PhpEngine should propagate charset to its helpers

@fabpot fabpot merged commit ed9e48b into symfony:2.3 Apr 10, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Success: Travis, fabbot
Details

@stloyd stloyd deleted the stloyd:bugfix/templating_charset branch Apr 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.