Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] removed $csrfTokenManager type hint from SimpleFormAuthenticationListener constructor argument #10784

Merged
merged 1 commit into from Apr 25, 2014

Conversation

Projects
None yet
2 participants
@bixelsnl
Copy link
Contributor

commented Apr 25, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets [#10452]
License MIT
Doc PR n/a
@@ -50,13 +50,13 @@ class SimpleFormAuthenticationListener extends AbstractAuthenticationListener
* successful, or failed authentication attempt
* @param LoggerInterface $logger A LoggerInterface instance
* @param EventDispatcherInterface $dispatcher An EventDispatcherInterface instance
* @param CsrfTokenManagerInterface $csrfTokenManager A CsrfTokenManagerInterface instance
* @param $csrfTokenManager

This comment has been minimized.

Copy link
@fabpot

fabpot Apr 25, 2014

Member

This change should be reverted as this is what we expect. The removal of the type hint in the method signature is just to take care of BC.

This comment has been minimized.

Copy link
@bixelsnl

bixelsnl Apr 25, 2014

Author Contributor

OK; I've amended the commit to put this back.

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 25, 2014

Thank you @choonge.

@fabpot fabpot merged commit b020207 into symfony:2.4 Apr 25, 2014

0 of 2 checks passed

continuous-integration/travis-ci The Travis CI build is in progress
Details
default Success: fabbot — Pending: Travis
Details

fabpot added a commit that referenced this pull request Apr 25, 2014

bug #10784 [Security] removed $csrfTokenManager type hint from Simple…
…FormAuthenticationListener constructor argument (choonge)

This PR was merged into the 2.4 branch.

Discussion
----------

[Security] removed $csrfTokenManager type hint from SimpleFormAuthenticationListener constructor argument

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | [#10452]
| License       | MIT
| Doc PR        | n/a

Commits
-------

b020207 [Security] removed $csrfTokenManager type hint from SimpleFormAuthenticationListener constructor argument

@bixelsnl bixelsnl deleted the bixelsnl:ticket_10452 branch Apr 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.