Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fixed the rendering of exceptions on HHVM with a terminal width #10789

Merged
merged 1 commit into from Apr 27, 2014

Conversation

Projects
None yet
2 participants
@stof
Copy link
Member

commented Apr 26, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR -

If getTerminalWidth returns a big integer (which is the case in Behat 2.5 which overwrites the method to return PHP_INT_MAX to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default.

@fabpot fabpot merged commit 6e57380 into symfony:2.3 Apr 27, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Success: Travis, fabbot
Details

fabpot added a commit that referenced this pull request Apr 27, 2014

bug #10789 [Console] Fixed the rendering of exceptions on HHVM with a…
… terminal width (stof)

This PR was merged into the 2.3 branch.

Discussion
----------

[Console] Fixed the rendering of exceptions on HHVM with a terminal width

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | -

If ``getTerminalWidth`` returns a big integer (which is the case in Behat 2.5 which overwrites the method to return ``PHP_INT_MAX`` to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default.

Commits
-------

6e57380 [Console] Fixed the rendering of exceptions on HHVM with a terminal width

@stof stof deleted the stof:console_hhvm_fix branch May 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.