[Security] Add check for supported attributes in AclVoter #10863

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@artursvonda
Contributor

artursvonda commented May 7, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Couldn't get the tests to pass but the issues were unrelated to the change.

This fixes issues with Attribute containing ExpressionLanguage instance when using allow_if.

Add check for supported attributes. Since attribute can be Expression…
…Language instance, this was throwing error.
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof May 7, 2014

Member

Please add a test covering this bug to avoid regressions

Member

stof commented May 7, 2014

Please add a test covering this bug to avoid regressions

@jakzal jakzal added the Security label May 7, 2014

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 8, 2014

Member

Thank you @artursvonda.

Member

fabpot commented May 8, 2014

Thank you @artursvonda.

fabpot added a commit that referenced this pull request May 8, 2014

bug #10863 [Security] Add check for supported attributes in AclVoter …
…(artursvonda)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10863).

Discussion
----------

[Security] Add check for supported attributes in AclVoter

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Couldn't get the tests to pass but the issues where unrelated to change.

This fixes issues with Attribute containing ExpressionLanguage instance when using allow_if.

Commits
-------

a605a3d [Security] Add check for supported attributes in AclVoter

@fabpot fabpot closed this May 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment