[HttpKernel] Fix "absolute path" when we look to the cache directory #10937

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

BenoitLeveque commented May 18, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

We should get __DIR__ instead of __DIR__ . '/.'

I've seen this issue when trying to play with the symfony standard new directory structure

Fix "absolute path" when we look to the cache directory
We should get __DIR__ instead of __DIR__ . '/.'

@BenoitLeveque BenoitLeveque changed the title from Fix "absolute path" when we look to the cache directory to [HttpKernel] Fix "absolute path" when we look to the cache directory May 18, 2014

Owner

fabpot commented May 18, 2014

Good catch, thanks @BenoitLeveque.

fabpot added a commit that referenced this pull request May 18, 2014

bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache…
… directory (BenoitLeveque)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10937).

Discussion
----------

[HttpKernel] Fix "absolute path" when we look to the cache directory

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

We should get ``__DIR__`` instead of ``__DIR__ . '/.'``

I've seen this issue when trying to play with the symfony standard new directory structure

Commits
-------

4735e56 Fix "absolute path" when we look to the cache directory

@fabpot fabpot closed this May 18, 2014

fabpot added a commit that referenced this pull request May 26, 2014

Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to t…
…he cache directory (BenoitLeveque)"

This reverts commit 7dc8931, reversing
changes made to 309046a.

fabpot added a commit that referenced this pull request May 26, 2014

Merge branch '2.3' into 2.4
* 2.3:
  Revert "bug #10894 [HttpKernel] removed absolute paths from the generated container (fabpot)"
  Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)"
  Revert "fixed CS"
  Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"
  Revert "[HttpKernel] simplified some tests"
  [HttpKernel] simplified some tests
  Make rootPath part of regex greedy

Conflicts:
	src/Symfony/Component/HttpKernel/Tests/KernelTest.php

fabpot added a commit that referenced this pull request May 26, 2014

Merge branch '2.4' into 2.5
* 2.4:
  Revert "bug #10894 [HttpKernel] removed absolute paths from the generated container (fabpot)"
  Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)"
  Revert "fixed CS"
  Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"
  Revert "[HttpKernel] simplified some tests"
  [HttpKernel] simplified some tests
  Make rootPath part of regex greedy

fabpot added a commit that referenced this pull request May 26, 2014

Merge branch '2.5'
* 2.5:
  Revert "bug #10894 [HttpKernel] removed absolute paths from the generated container (fabpot)"
  Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)"
  Revert "fixed CS"
  Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"
  Revert "[HttpKernel] simplified some tests"
  [HttpKernel] simplified some tests
  Make rootPath part of regex greedy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment