Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Security] Security tweaks to SecurityExtension #1111
Comments in the commit message. Due to their nature, the DI Extension classes tend to be hard to read. This includes several changes to
Side note: I think the way that factories are processed (by calling
These extension classes are a pain to test since they're - effectively - just one giant public method with tons of logic.
Instead of backing out of these changes (which I hope add some clarity, but obviously I don't want to break anything) can we think of better way to organize things so that unit tests make sense? This entire "glue" layer of Symfony is complex and not tested.
The easiest thing I can think of is to make some of the private methods public. Obviously, they're not really meant to be public, but they would be testable and it would also help separate and define the individual "jobs" of each of these methods.
good luck then :p
On Thu, May 26, 2011 at 4:43 PM, stof <
In its current form, we cannot merge it, but I see several options going forward:
a) extracting the doc changes
I don't have time to work on the first two atm, but if someone has time, I think Ryan's doc changes are overall very good although most people probably won't look at the SecurityExtension.