New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dutch translations #11203

Closed
wants to merge 2 commits into
base: 2.4
from

Conversation

Projects
None yet
6 participants
@wouterj
Member

wouterj commented Jun 23, 2014

No description provided.

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 23, 2014

👍

1 similar comment
@stof

This comment has been minimized.

Member

stof commented Jun 23, 2014

👍

</trans-unit>
<trans-unit id="75">
<source>The image is square ({{ width }}x{{ height }}px). Square images are not allowed.</source>
<target>De afbeelding is een vierkant ({{ width }}x{{ height }}px). Vierkante afbeeldingen zijn niet toegestaan.</target>

This comment has been minimized.

@javiereguiluz

javiereguiluz Jun 23, 2014

Member

I can't speak Dutch, but does De afbeelding is een vierkant mean The image is a square (wrong) or The image has a square form (this is the original English meaning)?

This comment has been minimized.

@wouterj

wouterj Jun 23, 2014

Member

The first one. But I've never heard anyone saying "a square form" ("een vierkante vorm") in Dutch.

This comment has been minimized.

@javiereguiluz

javiereguiluz Jun 23, 2014

Member

I'm afraid that the first one is wrong :( The image isn't a "square as a noun" but a "square as an adjective" . The only thing that we know about the image is that its height equals its width.

This comment has been minimized.

@wouterj

wouterj Jun 23, 2014

Member

I'm sorry, but I don't get what you mean. What is the difference between "square as noun" and "square as adjective"? Both describe a square form, don't they?

This comment has been minimized.

@javiereguiluz

javiereguiluz Jun 23, 2014

Member

In English (and Spanish):

  • "This is a square" == noun
  • "This is square" == adjective

I don't know if it's correct, but the equivalent in Dutch would be: De afbeelding is vierkant

This comment has been minimized.

@javiereguiluz

javiereguiluz Jun 23, 2014

Member

Maybe this graph can help me to better explain myself:

square

In English, Spanish, Portuguese, etc. is completely different "being square" and "being a square". Maybe Dutch doesn't care about this difference.

This comment has been minimized.

@wouterj

wouterj Jun 23, 2014

Member

I still don't get it, but I've changed to it be an adjective

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 25, 2014

Thank you @wouterj.

fabpot added a commit that referenced this pull request Jun 25, 2014

minor #11203 Added missing dutch translations (WouterJ)
This PR was squashed before being merged into the 2.4 branch (closes #11203).

Discussion
----------

Added missing dutch translations

Commits
-------

bd9283e Added missing dutch translations

@fabpot fabpot closed this Jun 25, 2014

@wouterj wouterj deleted the wouterj:patch-8 branch Jun 25, 2014

romainneutron added a commit that referenced this pull request Jul 7, 2014

minor #11336 [Process] add missing docblock for ProcessBuilder::addEn…
…vironmentVariables() (xabbuh)

This PR was merged into the 2.4 branch.

Discussion
----------

[Process] add missing docblock for ProcessBuilder::addEnvironmentVariables()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

9e1d11d add missing docblock for ProcessBuilder::addEnvironmentVariables()
ce29e0a bug #11283 [SecurityBundle] Remove Expression Language services when the component is unavailable (thewilkybarkid)
557a82a Remove Expression Language services when the component is unavailable
5b2e34f Merge branch '2.3' into 2.4
85af997 bug #11259 [Config] Fixed failed config schema loads due to libxml_disable_entity_loader usage (ccorliss)
de2bef5 Fixed failed config schema loads due to libxml_disable_entity_loader usage.
8a68e6c bug #11234 [ClassLoader] fixed PHP warning on PHP 5.3 (fabpot)
3b9902a enabled PHP 5.6 for tests
cd7fe02 bug #11179 [Process] Fix ExecutableFinder with open basedir (cs278)
b8f8c0e [Process] Fix ExecutableFinder with open basedir
fa2d337 bug #11242 [CssSelector] Refactored the CssSelector to remove the circular object graph (stof)
994f81f Refactored the CssSelector to remove the circular object graph
1045adf bug #11219 [DomCrawler] properly handle buttons with single and double quotes insid... (xabbuh)
84be8de minor #11230 Fix mocks to support >=5.5.14 and >=5.4.30 (jpauli)
1c5c694 Fix mocks to support >=5.5.14 and >=5.4.30
7b2e3d9 [ClassLoader] fixed PHP warning on PHP 5.3
7b0ed91 minor #11225 [Validator] added Lithuanian translation for empty file (Tadcka)
a954083 [Validator] added Lithuanian translation for empty file
803b06b bug #11220 [Components][Serializer] optional constructor arguments can be omitted during the denormalization process (xabbuh)
05c51f5 minor #11203 Added missing dutch translations (WouterJ)
bd9283e Added missing dutch translations
5bb2345 [Components][Serializer] optional constructor arguments can be omitted during the denormalization process
cbbdbe4 [DomCrawler] properly handle buttons with single and double quotes inside the name attribute
f6eb9b6 minor #11201 [Validator] Added missing pt and pt_BR translations (dcsg)
71a2b59 Added missing pt and pt_BR translations
0067952 minor #11195 [Validator] Add missing ru translations (megazoll)
71eb8a8 [Validator] Add missing ru translations
f45f2df minor #11191 [Tests] fix tests due to recent changes in PHP's behavior (xabbuh)
bc8042d don't disable constructor calls to mockups of classes that extend internal PHP classes
f4a3c7a special handling for the JsonDescriptor to work around changes in PHP's JSON pretty printer
f2bdc22 fixed previous merge
b387477 Merge branch '2.3' into 2.4
eeeae94 minor #11187 [Tests] don't disable constructor calls to mockups of classes that extend intern... (xabbuh)
ff00dcc bug #11186 Added missing `break` statement (apfelbox)
5af2802 Added missing `break` statement
2c726b8 don't disable constructor calls to mockups of classes that extend internal PHP classes
96bc061 minor #11182 Small comment update according to PSR-2 (apfelbox)
31b1dff Small comment update according to PSR-2
7d4f4f2 bug #11169 [Console] Fixed notice in DialogHelper (florianv)
ff6c65e [Console] Fixed notice in DialogHelper
fbf92e5 bug #11144 [HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6 (kicken)
bd11e92 minor #11136 [Filesystem] Fix test suite on OSX (romainneutron)
2a0e8e3 [HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6
e26f08e [Filesystem] Fix test suite on OSX
185aafa minor #11077 [TwigBundle] [Tests] Add framework-bundle (clemens-tolboom)
a12471d Add framework-bundle

romainneutron added a commit that referenced this pull request Jul 7, 2014

minor #11337 [Process] fix the return types (xabbuh)
This PR was merged into the 2.5 branch.

Discussion
----------

[Process] fix the return types

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

3466601 fix the return types
6a41ca0 minor #11271 [Validator] Added missing Slovak translations (pulzarraider)
585a045 Added SK translations
a22858b Merge branch '2.4' into 2.5
5b2e34f Merge branch '2.3' into 2.4
85af997 bug #11259 [Config] Fixed failed config schema loads due to libxml_disable_entity_loader usage (ccorliss)
de2bef5 Fixed failed config schema loads due to libxml_disable_entity_loader usage.
8a68e6c bug #11234 [ClassLoader] fixed PHP warning on PHP 5.3 (fabpot)
3b9902a enabled PHP 5.6 for tests
cd7fe02 bug #11179 [Process] Fix ExecutableFinder with open basedir (cs278)
b8f8c0e [Process] Fix ExecutableFinder with open basedir
fa2d337 bug #11242 [CssSelector] Refactored the CssSelector to remove the circular object graph (stof)
994f81f Refactored the CssSelector to remove the circular object graph
1045adf bug #11219 [DomCrawler] properly handle buttons with single and double quotes insid... (xabbuh)
84be8de minor #11230 Fix mocks to support >=5.5.14 and >=5.4.30 (jpauli)
1c5c694 Fix mocks to support >=5.5.14 and >=5.4.30
7b2e3d9 [ClassLoader] fixed PHP warning on PHP 5.3
7b0ed91 minor #11225 [Validator] added Lithuanian translation for empty file (Tadcka)
a954083 [Validator] added Lithuanian translation for empty file
803b06b bug #11220 [Components][Serializer] optional constructor arguments can be omitted during the denormalization process (xabbuh)
05c51f5 minor #11203 Added missing dutch translations (WouterJ)
bd9283e Added missing dutch translations
5bb2345 [Components][Serializer] optional constructor arguments can be omitted during the denormalization process
cbbdbe4 [DomCrawler] properly handle buttons with single and double quotes inside the name attribute
f6eb9b6 minor #11201 [Validator] Added missing pt and pt_BR translations (dcsg)
71a2b59 Added missing pt and pt_BR translations
4450197 Merge branch '2.4' into 2.5
0067952 minor #11195 [Validator] Add missing ru translations (megazoll)
71eb8a8 [Validator] Add missing ru translations
f45f2df minor #11191 [Tests] fix tests due to recent changes in PHP's behavior (xabbuh)
bc8042d don't disable constructor calls to mockups of classes that extend internal PHP classes
f4a3c7a special handling for the JsonDescriptor to work around changes in PHP's JSON pretty printer
76d3c9e Merge branch '2.4' into 2.5
f2bdc22 fixed previous merge
b387477 Merge branch '2.3' into 2.4
eeeae94 minor #11187 [Tests] don't disable constructor calls to mockups of classes that extend intern... (xabbuh)
ff00dcc bug #11186 Added missing `break` statement (apfelbox)
5af2802 Added missing `break` statement
2c726b8 don't disable constructor calls to mockups of classes that extend internal PHP classes
96bc061 minor #11182 Small comment update according to PSR-2 (apfelbox)
31b1dff Small comment update according to PSR-2
a50aca0 bug #11168 [YAML] fix merge node (<<) (Tobion)
cd0309f minor #11162 [Console] remove weird use statement (cordoval)
dee1562 [Yaml] fix overwriting of keys after merged map
8c621ab [Yaml] fix priority of sequence merges according to spec
bebd18c bug #11170 [Console] Fixed notice in QuestionHelper (florianv)
7d4f4f2 bug #11169 [Console] Fixed notice in DialogHelper (florianv)
9fe4b88 [Console] Fixed notice in QuestionHelper
ff6c65e [Console] Fixed notice in DialogHelper
02614e0 [Yaml] refactoring of merges for performance
c117e8e [Console] remove weird use statement
fbf92e5 bug #11144 [HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6 (kicken)
bd11e92 minor #11136 [Filesystem] Fix test suite on OSX (romainneutron)
2a0e8e3 [HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6
e26f08e [Filesystem] Fix test suite on OSX
185aafa minor #11077 [TwigBundle] [Tests] Add framework-bundle (clemens-tolboom)
a12471d Add framework-bundle
@flip111

This comment has been minimized.

Contributor

flip111 commented Jul 26, 2014

That's highly unusual to use "vierkant" as predicative adjective in dutch. In fact i have never ever seen it in my life. It's like one of those english text translated by chinese people, it might be correct english but it certainly raises an eyebrow.
It's so unusual that in speech people start using the suffix "tig". While this suffix is not (yet) in the official dutch dictionary for "vierkant". It can be found in several other dictionaries.
By the way, using "vierkant" as attributive adjective is totally acceptable though (but that doesn't seem to help much with this case)

@wouterj

This comment has been minimized.

Member

wouterj commented Jul 26, 2014

@flip111 if I understand you correctly, my version was the correct one?

@wouterj

This comment has been minimized.

Member

wouterj commented Jul 26, 2014

Where is the vierkantig translation you refer to? (which indeed isn't used (much) in Dutch (at least not in The Netherlands) )

It's not used. @flip111 commented on this discussion I had with @javiereguiluz in this PR: #11203 (comment)

@1emming

This comment has been minimized.

Contributor

1emming commented Jul 26, 2014

Ah I see, thanks for clearing that up, still +1 for your fix :)
I think @javiereguiluz was hinting to this:

The image size, width and height, are the same (right image in this comment):
The image is square -> De afbeelding is vierkant

The image is might be of any dimension but contains a drawing of a square (left image in his comment):
The image is of a square -> De afbeelding is (van) een vierkant

That is why De afbeelding is vierkant is correct :)

@javiereguiluz

This comment has been minimized.

Member

javiereguiluz commented Jul 26, 2014

@1emming you got my point perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment