Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Validator] Improve UserPassword message #11383

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
7 participants
Contributor

redstar504 commented Jul 12, 2014

Q A
Fixed tickets None
License MIT

This validator message is not proper English.

Member

jakzal commented Jul 12, 2014

You should update translations in the same PR. symfony/validator is only a mirror repository.

Also, you need to update the message source in all the translation files (not just English).

@redstar504 redstar504 changed the title from Improve UserPassword validator message to [Validator] Improve UserPassword message Jul 13, 2014

Contributor

redstar504 commented Jul 13, 2014

@jakzal How's that?

Contributor

redstar504 commented Jul 13, 2014

Hmm, I don't know why these translation fixes would cause the build to fail so extensively.

Are quotes not allowed in the xlf files?

Owner

fabpot commented Jul 13, 2014

The problems are not related to your changes, so no worries.

Member

stof commented Jul 13, 2014

changing the source of the translation is a bC break: if a project redefines the translation message or adds another locale, it will not be used anymore after this change. The safe way would be to change it only in the English translation message (this is an advantage of not using the English string as source btw)

Member

weaverryan commented Jul 13, 2014

@redstar504 Stof is right - I think we will need to change only the english translation. I'm not sure if we can/should break BC, even though I'd love to have the default message be the correct English.

Can someone else back this up to be sure? I don't want to keep making @redstar504 change his PR if we are able to break this translation key BC.

Owner

fabpot commented Jul 14, 2014

IMO, we should only change the English translation in 2.3 and change the key in master.

Contributor

redstar504 commented Jul 14, 2014

Okay in that case this PR is 👍, and I will send separate PR for 2.3?

Owner

fabpot commented Jul 14, 2014

@redstar504 yes, please.

Contributor

redstar504 commented Jul 14, 2014

Okay done in #11387.

@fabpot fabpot added a commit that referenced this pull request Jul 15, 2014

@fabpot fabpot minor #11387 [2.3] [Validator] Fix UserPassword validator translation…
… (redstar504)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [Validator] Fix UserPassword validator translation

| Q             | A
| ------------- | ---
| Fixed tickets | None
| License       | MIT

Fixes the UserPassword translation message only for 2.3 as discussed in symfony/symfony#11383.

Commits
-------

73d50ed Fix UserPassword validator translation
3c54659

@fabpot fabpot added a commit to symfony/validator that referenced this pull request Jul 15, 2014

@fabpot fabpot minor #11387 [2.3] [Validator] Fix UserPassword validator translation…
… (redstar504)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [Validator] Fix UserPassword validator translation

| Q             | A
| ------------- | ---
| Fixed tickets | None
| License       | MIT

Fixes the UserPassword translation message only for 2.3 as discussed in symfony/symfony#11383.

Commits
-------

73d50ed Fix UserPassword validator translation
228f986
Contributor

webmozart commented Jul 18, 2014

If I'm not mistaken this can be merged now?

Owner

fabpot commented Jul 18, 2014

@redstar504 Can you add a note about this "BC break" in the Validator changelog?

redstar504 added some commits Jul 12, 2014

@redstar504 redstar504 Improve UserPassword message ec5f703
@redstar504 redstar504 Add BC break info to changelog 73600ef
Contributor

redstar504 commented Jul 22, 2014

Done. @fabpot

Owner

fabpot commented Jul 23, 2014

👍

Owner

fabpot commented Jul 23, 2014

Thank you @redstar504.

@fabpot fabpot closed this Jul 23, 2014

@fabpot fabpot added a commit that referenced this pull request Jul 23, 2014

@fabpot fabpot minor #11383 [Validator] Improve UserPassword message (redstar504)
This PR was squashed before being merged into the 2.6-dev branch (closes #11383).

Discussion
----------

[Validator] Improve UserPassword message

| Q             | A
| ------------- | ---
| Fixed tickets | None
| License       | MIT

This validator message is not proper English.

Commits
-------

d57471e [Validator] Improve UserPassword message
1fdd3df

@fago fago pushed a commit to fago/Validator that referenced this pull request Apr 18, 2015

@fabpot fabpot minor #11387 [2.3] [Validator] Fix UserPassword validator translation…
… (redstar504)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [Validator] Fix UserPassword validator translation

| Q             | A
| ------------- | ---
| Fixed tickets | None
| License       | MIT

Fixes the UserPassword translation message only for 2.3 as discussed in symfony/symfony#11383.

Commits
-------

73d50ed Fix UserPassword validator translation
a3aff1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment