Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftmailerBridge] Bump allowed versions of swiftmailer #11892

Conversation

Projects
None yet
3 participants
@ymc-dabe
Copy link
Contributor

commented Sep 9, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (but SwiftmailerBridge itself does not contain any tests)
Fixed tickets -
License MIT
Doc PR -

Current version of Swiftmailer is 5.2.1, while (previously to this commit)
the version installed by composer was 5.0.3.

This is rather important, since 5.2.1 closes a security issue that 5.0.3 is
vulnarable to (swiftmailer/swiftmailer#494).

@ymc-dabe ymc-dabe force-pushed the ymc-dabe:SwiftmailerBridge-Bump-allowed-versions-of-swiftmailer branch from ae9add7 to 108b61a Sep 9, 2014

@stof

This comment has been minimized.

Copy link
Member

commented Sep 10, 2014

IMO, all 5.x versions should be allowed given that Swiftmailer now follows semver

[SwiftmailerBridge] Bump allowed versions of swiftmailer
Current version of Swiftmailer is 5.2.1, while (previously to this commit)
the version installed by composer was 5.0.3.

This is rather important, since 5.2.1 closes a security issue that 5.0.3 is
vulnarable to (swiftmailer/swiftmailer#494).

@ymc-dabe ymc-dabe force-pushed the ymc-dabe:SwiftmailerBridge-Bump-allowed-versions-of-swiftmailer branch from 108b61a to a5e3fc9 Sep 10, 2014

@ymc-dabe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2014

I'm not sure if Swiftmailer follows semantic versioning, but I suspect it to. I therefore just updated the pull request to require ">=4.2.0,<6.0-dev" (instead of ">=4.2.0,<5.3-dev").
Thanks for the hint.

@stof

This comment has been minimized.

Copy link
Member

commented Sep 13, 2014

👍

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 13, 2014

Thank you @ymc-dabe.

@fabpot fabpot merged commit a5e3fc9 into symfony:2.3 Sep 13, 2014

1 of 2 checks passed

default Success: Travis, fabbot — Failure: app.shippable.com
Details
continuous-integration/travis-ci The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Sep 13, 2014

bug #11892 [SwiftmailerBridge] Bump allowed versions of swiftmailer (…
…ymc-dabe)

This PR was merged into the 2.3 branch.

Discussion
----------

[SwiftmailerBridge] Bump allowed versions of swiftmailer

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes (but SwiftmailerBridge itself does not contain any tests)
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Current version of Swiftmailer is 5.2.1, while (previously to this commit)
the version installed by composer was 5.0.3.

This is rather important, since 5.2.1 closes a security issue that 5.0.3 is
vulnarable to (swiftmailer/swiftmailer#494).

Commits
-------

a5e3fc9 [SwiftmailerBridge] Bump allowed versions of swiftmailer
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 16, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.