[WebProfilerBundle] Show AJAX requests in the symfony profiler toolbar #12000
Conversation
fabpot
force-pushed
the
profile_ajax_requests
branch
from
069cb62
to
a5a6ee3
Compare
|
👍 |
1 similar comment
|
👍 |
|
👍 ;) |
|
happy 1️⃣ 2️⃣ 0️⃣ 0️⃣ 0️⃣ th issue/PR |
fabpot
force-pushed
the
profile_ajax_requests
branch
from
a5a6ee3
to
b66f39a
Compare
|
Oh, this icon... Is this recent screenshot? |
|
@shoomyth Unfortunately yes. But we still have 2 full months to get a nicer one. |
| requestCounter[0].className = className; | ||
| }; | ||
|
|
||
| {% if (excluded_ajax_paths is defined) %} |
|
@stof comments taken into account |
|
@stof Any other comments before I merge this one? |
| @@ -38,14 +38,16 @@ class WebDebugToolbarListener implements EventSubscriberInterface | |||
| protected $interceptRedirects; | |||
| protected $mode; | |||
| protected $position; | |||
| protected $excludedAjaxPaths; | |||
There was a problem hiding this comment.
I think we should make it private (others should already be private btw as there is no reason to provide extension points here, but we cannot change it for BC reasons)
|
Apart from the JS optimization I suggestion, this is good to me |
|
@fabpot it looks like fabbot is applying a CS fixer which is at the Contrib level rather than the Symfony one. This looks weird to me, given that the Symfony level is precisely defined as being the rules applied in Symfony |
…profiler toolbar (Burgov, fabpot, stof) This PR was merged into the 2.6-dev branch. Discussion ---------- [WebProfilerBundle] Show AJAX requests in the symfony profiler toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Adds AJAX requests in the web debug toolbar. See #8896 for the original discussion.  Commits ------- 16d1b35 optimized JS for the AJAX section of the toolbar 2e708d7 made minor tweaks to JS code 8e4c603 replaced the AJAX icon with a smaller one b66f39a removed hack 9c74fcc removed uneeded web_profiler.debug_toolbar.excluded_ajax_paths parameter in the container d43edaf [WebProfilerBundle] improved the ajax section of the WDT 37f7dd7 [WebProfilerBundle] Show AJAX requests in the symfony profiler toolbar
Adds AJAX requests in the web debug toolbar.
See #8896 for the original discussion.