Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fixed Choice when an empty array is used in the "choices" option #14463

Merged
merged 1 commit into from Apr 27, 2015

Conversation

@webmozart
Copy link
Contributor

webmozart commented Apr 24, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13853
License MIT
Doc PR -

This is a backport of #14448 for the 2.3 branch.

@Tobion

This comment has been minimized.

Copy link
Member

Tobion commented Apr 24, 2015

👍 But next time please don't diverge from symfony merging strategy: merge in 2.3 first and then upwards instead of backporting.

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 24, 2015

I agree with @Tobion.

@webmozart webmozart added the Validator label Apr 24, 2015
@webmozart

This comment has been minimized.

Copy link
Contributor Author

webmozart commented Apr 24, 2015

@Tobion yep, sorry

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Apr 24, 2015

👍

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 27, 2015

Thank you @webmozart.

@fabpot fabpot merged commit 8bf8556 into symfony:2.3 Apr 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
fabpot added a commit that referenced this pull request Apr 27, 2015
…e "choices" option (webmozart)

This PR was merged into the 2.3 branch.

Discussion
----------

[Validator] Fixed Choice when an empty array is used in the "choices" option

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13853
| License       | MIT
| Doc PR        | -

This is a backport of #14448 for the 2.3 branch.

Commits
-------

8bf8556 [Validator] Fixed Choice when an empty array is used in the "choices" option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.