[Security] #15764. Use SessionAuthenticationStrategy on RememberMe login #16108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this also affect Symfony 2.3? |
| */ | ||
| public function __construct(TokenStorageInterface $tokenStorage, RememberMeServicesInterface $rememberMeServices, AuthenticationManagerInterface $authenticationManager, LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, $catchExceptions = true) | ||
| public function __construct(TokenStorageInterface $tokenStorage, RememberMeServicesInterface $rememberMeServices, AuthenticationManagerInterface $authenticationManager, LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, $catchExceptions = true, SessionAuthenticationStrategyInterface $sessionStrategy) |
There was a problem hiding this comment.
The new argument must be optional (people can use it outside the framework which would break their applications when upgrading).
There was a problem hiding this comment.
@xabbuh, made it optional
|
Status: Needs work |
@xabbuh, looks like it does, would it be better to create a PR for 2.3? |
|
@s12v If I did not overlook anything the switch can be done when merging. So there's no need to create a new pull request. |
| @@ -53,6 +55,7 @@ public function __construct(TokenStorageInterface $tokenStorage, RememberMeServi | |||
| $this->logger = $logger; | |||
| $this->dispatcher = $dispatcher; | |||
| $this->catchExceptions = $catchExceptions; | |||
| $this->sessionStrategy = $sessionStrategy; | |||
There was a problem hiding this comment.
You need to add the declaration of this property.
There was a problem hiding this comment.
@xabbuh, oh, right, thanks!
Regenerate session ID with default session strategy
|
👍 for merge in 2.3. |
|
👍 |
| */ | ||
| public function __construct(TokenStorageInterface $tokenStorage, RememberMeServicesInterface $rememberMeServices, AuthenticationManagerInterface $authenticationManager, LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, $catchExceptions = true) | ||
| public function __construct(TokenStorageInterface $tokenStorage, RememberMeServicesInterface $rememberMeServices, AuthenticationManagerInterface $authenticationManager, LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, $catchExceptions = true, SessionAuthenticationStrategyInterface $sessionStrategy = null) |
There was a problem hiding this comment.
The $catchExceptions argument is not in 2.3, so I'm going to merge this one on 2.7 instead.
|
Thank you @s12v. |
fabpot
added a commit
that referenced
this pull request
Oct 16, 2015
…memberMe login (s12v) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #16108). Discussion ---------- [Security] #15764. Use SessionAuthenticationStrategy on RememberMe login Regenerate session ID with default session strategy. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15764 | License | MIT | Doc PR | - Commits ------- 795c8b3 [Security] Use SessionAuthenticationStrategy on RememberMe login
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate session ID with default session strategy.