New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade information for the choice_value option #16849

Merged
merged 1 commit into from Dec 18, 2015

Conversation

Projects
None yet
4 participants
@peterrehm
Contributor

peterrehm commented Dec 5, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Relates to #14825 and #14377. The behaviour was changed with #16681 so a not in the upgrade information makes sense to me.

'Disabled' => Status::DISABLED,
'Ignored' => Status::IGNORED,
),
// choices_as_values will default to true in Symfony 3.0

This comment has been minimized.

@xabbuh

xabbuh Dec 10, 2015

Member

and setting it to something different is deprecated

This comment has been minimized.

@peterrehm

peterrehm Dec 10, 2015

Contributor

Updated accordingly.

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Dec 18, 2015

Member

will default -> defaults

@peterrehm peterrehm force-pushed the peterrehm:choice-value branch from 3aebcfd to 6375459 Dec 10, 2015

@peterrehm

This comment has been minimized.

Contributor

peterrehm commented Dec 17, 2015

@xabbuh Is this good to go?

@xabbuh

This comment has been minimized.

Member

xabbuh commented Dec 17, 2015

👍 LGTM

After:
```php
$form->add('status', 'choice', array(

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Dec 18, 2015

Member

'choice' -> ChoiceType::class

After (Symfony 2.8+):
```php
$form->add('status', 'choice', array(

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Dec 18, 2015

Member

'choice' -> ChoiceType::class

@peterrehm peterrehm force-pushed the peterrehm:choice-value branch from 6375459 to 28675c9 Dec 18, 2015

@peterrehm

This comment has been minimized.

Contributor

peterrehm commented Dec 18, 2015

@nicolas-grekas Good catch, updated.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 18, 2015

Thank you @peterrehm.

@nicolas-grekas nicolas-grekas merged commit 28675c9 into symfony:2.8 Dec 18, 2015

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 18, 2015

minor #16849 Upgrade information for the choice_value option (peterrehm)
This PR was merged into the 2.8 branch.

Discussion
----------

Upgrade information for the choice_value option

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Relates to #14825 and #14377. The behaviour was changed with #16681 so a not in the upgrade information makes sense to me.

Commits
-------

28675c9 Reflected the change of the choice_value option in the Upgrade information

@peterrehm peterrehm deleted the peterrehm:choice-value branch Dec 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment