New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] fix BC break introduced with prototype_data option #17044

Closed
wants to merge 4 commits into
base: 2.8
from

Conversation

Projects
None yet
6 participants
@memphys
Contributor

memphys commented Dec 17, 2015

Q A
Bug fix? [yes]
New feature? [no]
BC breaks? [no]
Deprecations? [no]
Tests pass? [no]
Fixed tickets [#15707]
License MIT
Doc PR []

This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity.

  • make the test work (can't figure yet how to test that prototype without prototype_data option has default values)

memphys added some commits Dec 17, 2015

@HeahDude

View changes

Show outdated Hide outdated src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php
@HeahDude

View changes

Show outdated Hide outdated src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php
@memphys

This comment has been minimized.

Show comment
Hide comment
@memphys

memphys Dec 17, 2015

Contributor

@HeahDude thanks! Made new commit, now test is passing.

Contributor

memphys commented Dec 17, 2015

@HeahDude thanks! Made new commit, now test is passing.

@memphys memphys changed the title from [WIP] [Form] fix BC break introduced with prototype_data option to [Form] fix BC break introduced with prototype_data option Dec 18, 2015

@sstok

View changes

Show outdated Hide outdated src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas
Member

nicolas-grekas commented Dec 18, 2015

👍

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 18, 2015

Member

Thank you @memphys.

Member

fabpot commented Dec 18, 2015

Thank you @memphys.

fabpot added a commit that referenced this pull request Dec 18, 2015

bug #17044 [Form] fix BC break introduced with prototype_data option …
…(memphys)

This PR was squashed before being merged into the 2.8 branch (closes #17044).

Discussion
----------

[Form] fix BC break introduced with prototype_data option

| Q             | A
| ------------- | ---
| Bug fix?      | [yes]
| New feature?  | [no]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [no]
| Fixed tickets | [#15707]
| License       | MIT
| Doc PR        | []

This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity.

- [x] make the test work (can't figure yet how to test that prototype without prototype_data option has default values)

Commits
-------

d73485a [Form] fix BC break introduced with prototype_data option

@fabpot fabpot closed this Dec 18, 2015

@memphys

This comment has been minimized.

Show comment
Hide comment
@memphys

memphys Dec 18, 2015

Contributor

@fabpot with pleasure!

Contributor

memphys commented Dec 18, 2015

@fabpot with pleasure!

@memphys memphys deleted the memphys:15707-fix-prototype-data-bc-break branch Dec 21, 2015

This was referenced Dec 26, 2015

nicolas-grekas added a commit that referenced this pull request Dec 29, 2015

bug #17162 [Form] Fix regression on Collection type (hason)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Fix regression on Collection type

Q | A
--- | ---
Bug fix? 	| yes
New feature? | no
BC breaks? | no
Deprecations? | no
Tests pass? | yes
Fixed tickets |
License | MIT
Doc PR |

A regression was introduced in #17044.

Commits
-------

bd686cd [Form] Fixed regression on Collection type

@memphys memphys referenced this pull request Feb 1, 2016

Merged

cadfem case for blog #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment