Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers #18179

Merged
merged 2 commits into from Mar 15, 2016

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Mar 15, 2016

Q A
Branch 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18077, #18067
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas changed the title Parse as int [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers Mar 15, 2016

if (false !== strpos($value, $decSep)) {
$type = \NumberFormatter::TYPE_DOUBLE;
} else {
$type = PHP_INT_SIZE === 8

This comment has been minimized.

Copy link
@javiereguiluz

javiereguiluz Mar 15, 2016

Member

Very minor comment: should this ternary condition be a one-liner?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 15, 2016

Author Member

it wouldn't enhance readability imho

@nicolas-grekas nicolas-grekas merged commit 03c008c into symfony:2.3 Mar 15, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 15, 2016

bug #18179 [Form] Fix NumberToLocalizedStringTransformer::reverseTran…
…sform with big integers (ovrflo, nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18077, #18067
| License       | MIT
| Doc PR        | -

Commits
-------

03c008c [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers
6b6073f [Form] Fix INT64 cast to float in IntegerType.

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:parse-as-int branch Mar 15, 2016

This was referenced Mar 25, 2016

@fabpot fabpot referenced this pull request Mar 30, 2016

Merged

Release v3.0.4 #18363

@fabpot fabpot referenced this pull request Apr 29, 2016

Merged

Release v2.3.40 #18669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.