Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyAccess] ->getValue() should be read-only #18603

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Apr 20, 2016

Q A
Branch? 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18601
License MIT
Doc PR -
@stof

This comment has been minimized.

Copy link
Member

commented Apr 20, 2016

Looks good to me. 👍

status: reviewed

@nicolas-grekas nicolas-grekas merged commit fa68529 into symfony:2.3 Apr 20, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 20, 2016

bug #18603 [PropertyAccess] ->getValue() should be read-only (nicolas…
…-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[PropertyAccess] ->getValue() should be read-only

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18601
| License       | MIT
| Doc PR        | -

Commits
-------

fa68529 [PropertyAccess] ->getValue() should be read-only

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-ro-pa branch Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.