Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix BC break introduced by #18101 #18925

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@dunglas
Copy link
Member

commented May 31, 2016

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #18101 (comment)
License MIT
Doc PR n/a
  • Fix tests
@GuilhemN

This comment has been minimized.

Copy link
Contributor

commented May 31, 2016

Status: Reviewed
👍 looks like a good workaround

@dunglas dunglas changed the title Fix BC break introduced by #18101 [Console] Fix BC break introduced by #18101 May 31, 2016

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

Thank you @dunglas.

fabpot added a commit that referenced this pull request Jun 1, 2016

bug #18925 [Console] Fix BC break introduced by #18101 (dunglas)
This PR was squashed before being merged into the 3.1 branch (closes #18925).

Discussion
----------

[Console] Fix BC break introduced by #18101

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #18101 (comment)
| License       | MIT
| Doc PR        | n/a

* [x] Fix tests

Commits
-------

7a5a139 [Console] Fix BC break introduced by #18101

@fabpot fabpot closed this Jun 1, 2016

@fabpot fabpot referenced this pull request Jun 15, 2016

Merged

Release v3.1.1 #19055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.