New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #19183 to add support for new PHP MongoDB extension in sessions. #19186

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@omanizer
Contributor

omanizer commented Jun 25, 2016

Q A
Branch? 3.0
Bug fix? yes
New feature? yes (ish)
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #19183
License MIT
Doc PR
@Simperfit

This comment has been minimized.

Show comment
Hide comment
@Simperfit

Simperfit Jun 26, 2016

Contributor

Could you please update the test according to this class ?

Contributor

Simperfit commented Jun 26, 2016

Could you please update the test according to this class ?

@ro0NL

This comment has been minimized.

Show comment
Hide comment
@ro0NL

ro0NL Jun 26, 2016

Contributor

This is a duplicate of #18788 right?

Contributor

ro0NL commented Jun 26, 2016

This is a duplicate of #18788 right?

omanizer added some commits Jun 26, 2016

Improved fields array declaration to use less code. Modified unit tes…
…ts to utilize new mongodb extension's class names if mongodb extension exists.
@omanizer

This comment has been minimized.

Show comment
Hide comment
@omanizer

omanizer Jun 26, 2016

Contributor

@ro0NL This is a dup of that PR. I should have looked harder as I didn't see that one when I created this one. Happy to move things along on this one though if desired.

@Simperfit I've updated the tests accordingly.

Contributor

omanizer commented Jun 26, 2016

@ro0NL This is a dup of that PR. I should have looked harder as I didn't see that one when I created this one. Happy to move things along on this one though if desired.

@Simperfit I've updated the tests accordingly.

@omanizer

This comment has been minimized.

Show comment
Hide comment
@omanizer

omanizer Jun 26, 2016

Contributor

Looks like some builds are not passing. I hypothesize that it's due to this line:
@requires extension mongo or mongodb not actually causing the test to be skipped when it may need to be.

Has anyone done an "or" in a require statement before or does anyone know of a better way to accomplish this or any other thoughts?

Contributor

omanizer commented Jun 26, 2016

Looks like some builds are not passing. I hypothesize that it's due to this line:
@requires extension mongo or mongodb not actually causing the test to be skipped when it may need to be.

Has anyone done an "or" in a require statement before or does anyone know of a better way to accomplish this or any other thoughts?

@ro0NL

This comment has been minimized.

Show comment
Hide comment
@ro0NL

ro0NL Jun 27, 2016

Contributor

@omanizer sure, just check the feedback from that one, looks like @fabpot wants to move on with this.

Contributor

ro0NL commented Jun 27, 2016

@omanizer sure, just check the feedback from that one, looks like @fabpot wants to move on with this.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jun 28, 2016

Member

As there is no feedback on #18788, @omanizer can you finish this one instead of closing it? You can also get some inspiration from the other PR if that makes sense for you.

Member

fabpot commented Jun 28, 2016

As there is no feedback on #18788, @omanizer can you finish this one instead of closing it? You can also get some inspiration from the other PR if that makes sense for you.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jul 1, 2016

Member

Thank you @omanizer.

Member

fabpot commented Jul 1, 2016

Thank you @omanizer.

fabpot added a commit that referenced this pull request Jul 1, 2016

bug #19186 Fix for #19183 to add support for new PHP MongoDB extensio…
…n in sessions. (omanizer)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #19186).

Discussion
----------

Fix for #19183 to add support for new PHP MongoDB extension in sessions.

| Q             | A
| ------------- | ---
| Branch?       | 3.0
| Bug fix?      | yes
| New feature?  | yes (ish)
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #19183
| License       | MIT
| Doc PR        |

Commits
-------

ebbc706 Fix for #19183 to add support for new PHP MongoDB extension in sessions.

@fabpot fabpot closed this Jul 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment