Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator][GroupSequence] fixed GroupSequence validation ignores PropetyMetadata of parent classes #19388

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@senaria
Copy link
Contributor

commented Jul 19, 2016

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19387
License MIT
Doc PR N/A

@senaria senaria force-pushed the netdudes:feature/issue-19387 branch 2 times, most recently from 4c7e2aa to 1ff0611 Jul 19, 2016

@senaria senaria force-pushed the netdudes:feature/issue-19387 branch from 1ff0611 to 9303fb2 Jul 21, 2016

@yakobe

This comment has been minimized.

Copy link

commented Jul 26, 2016

Can we merge this in?

@senaria

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2016

Is there any news about this? This possible solution looks like it would really help us out. Would be great if you could have a closer look.

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 25, 2016

@HeahDude Can you have a look at this one?

@HeahDude

This comment has been minimized.

Copy link
Member

commented Aug 25, 2016

LGTM 👍 @senaria Thank you for submitting this patch :)

Status: reviewed

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 26, 2016

Thank you @senaria.

fabpot added a commit that referenced this pull request Aug 26, 2016

bug #19388 [Validator][GroupSequence] fixed GroupSequence validation …
…ignores PropetyMetadata of parent classes (Sandro Hopf)

This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #19388).

Discussion
----------

[Validator][GroupSequence] fixed GroupSequence validation ignores PropetyMetadata of parent classes

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19387
| License       | MIT
| Doc PR        | N/A

Commits
-------

54a7eff [Validator][GroupSequence] fixed GroupSequence validation ignores PropertyMetadata of parent classes

@fabpot fabpot closed this Aug 26, 2016

@senaria

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2016

Brilliant. Thank you 👍

@peterrehm

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2016

I just proposed to revert this commit as it introduced a BC break. Please see my comment in the PR #20857, I think this might solve your issue as if the revert will happen it might break your application logic.

sorry for the additional work @yakobe! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.