Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Fix AbstractPipes::write() for a situation seen on HHVM (at least) #19508

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Aug 2, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets composer/composer#5381, composer/composer#5566
License MIT
Doc PR -

Even if I tried with my local hhvm, I can't reproduce the reported issues, yet it looks like some versions of HHVM trigger a notice here.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:wo-hhvm branch from 7c29f08 to 2bb2b9b Aug 2, 2016

@nicolas-grekas nicolas-grekas changed the title Wo hhvm [Process] Fix AbstractPipes::write() for a situation seen on HHVM (at least) Aug 2, 2016

@nicolas-grekas nicolas-grekas merged commit 2bb2b9b into symfony:2.7 Aug 3, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 3, 2016

bug #19508 [Process] Fix AbstractPipes::write() for a situation seen …
…on HHVM (at least) (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Fix AbstractPipes::write() for a situation seen on HHVM (at least)

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | composer/composer#5381, composer/composer#5566
| License       | MIT
| Doc PR        | -

Even if I tried with my local hhvm, I can't reproduce the reported issues, yet it looks like some versions of HHVM trigger a notice here.

Commits
-------

2bb2b9b [Process] Fix AbstractPipes::write() for a situation seen on HHVM (at least)

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:wo-hhvm branch Aug 3, 2016

This was referenced Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.