Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Alter container class instead of kernel name in cache:clear command #20147

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Oct 4, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19912
License MIT
Doc PR -

The decision to alter kernel's name instead of the container's class dates from cc3a40e
But this is causing issues such as #19912. Looking more carefully, the real intent is to change the container class and there is no need to alter also the kernel's name at this stage.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-warmup branch from c905536 to eb64488 Oct 4, 2016

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-warmup branch from eb64488 to 55de501 Oct 4, 2016

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-warmup branch from 55de501 to 73c9693 Oct 4, 2016

@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 5, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 73c9693 into symfony:2.7 Oct 5, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Oct 5, 2016

bug #20147 [FrameworkBundle] Alter container class instead of kernel …
…name in cache:clear command (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Alter container class instead of kernel name in cache:clear command

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19912
| License       | MIT
| Doc PR        | -

The decision to alter kernel's name instead of the container's class dates from cc3a40e
But this is causing issues such as #19912. Looking more carefully, the real intent is to change the container class and there is no need to alter also the kernel's name at this stage.

Commits
-------

73c9693 [FrameworkBundle] Alter container class instead of kernel name in cache:clear command

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cache-warmup branch Oct 5, 2016

This was referenced Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.