Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] Fix 7.1 compat #20291

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

commented Oct 24, 2016

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Should make CI green again with PHP 7.1 RC4.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-yaml-71 branch from ff7f408 to 89b78f2 Oct 24, 2016

@nicolas-grekas nicolas-grekas merged commit 89b78f2 into symfony:3.1 Oct 24, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Oct 24, 2016

bug #20291 [Yaml] Fix 7.1 compat (nicolas-grekas)
This PR was merged into the 3.1 branch.

Discussion
----------

[Yaml] Fix 7.1 compat

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Should make CI green again with PHP 7.1 RC4.

Commits
-------

89b78f2 [Yaml] Fix 7.1 compat

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-yaml-71 branch Oct 24, 2016

@fabpot fabpot referenced this pull request Oct 27, 2016

Merged

Release v3.1.6 #20316

@@ -507,17 +507,17 @@ public function testParseTimestampAsDateTimeObject($yaml, $year, $month, $day, $
$expected = new \DateTime($yaml);
$expected->setTimeZone(new \DateTimeZone('UTC'));
$expected->setDate($year, $month, $day);
$expected->setTime($hour, $minute, $second);
@$expected->setTime($hour, $minute, $second, 1000000 * ($second - (int) $second));

This comment has been minimized.

Copy link
@stof

stof Nov 3, 2016

Member

why do we need to silent it now ?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 3, 2016

Author Member

Because the method takes 3 args before 7.1, and 4 since 7.1 ($microseconds)

This comment has been minimized.

Copy link
@xabbuh

xabbuh Nov 3, 2016

Member

Why not making the call dependent on the executed PHP version then?

This comment has been minimized.

Copy link
@fabpot

fabpot Nov 3, 2016

Member

👍

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 3, 2016

Author Member

I had HHVM in mind, I don't know if the version check will be valid (now or later when they'll implement this). Do as you prefer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.