Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name #20474

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
5 participants
@fancyweb
Copy link
Contributor

commented Nov 10, 2016

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR symfony/symfony-docs#7139

This is a follow up PR to #20327.

I also decided to improve the current is_numeric() check that is done by a truer one. The current limitation is that a PCRE subpattern name must not start with a digit which is different.

@javiereguiluz javiereguiluz changed the title [Routing] Fail properly when a route parameter name cannot be used as… [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name Nov 10, 2016

fancyweb added some commits Nov 10, 2016

*
* @var int
*/
const VARIABLE_MAXIMUM_LENGTH = 32;

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 25, 2016

Member

please add @internal also so we don't have to apply the bc policy on this constant

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 25, 2016

👍

@stof

This comment has been minimized.

Copy link
Member

commented Nov 25, 2016

👍

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 25, 2016

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Nov 25, 2016

bug #20474 [Routing] Fail properly when a route parameter name cannot…
… be used as a PCRE subpattern name (fancyweb)

This PR was squashed before being merged into the 2.7 branch (closes #20474).

Discussion
----------

[Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#7139

This is a follow up PR to #20327.

I also decided to improve the current `is_numeric()` check that is done by a truer one. The current limitation is that a PCRE subpattern name must not start with a digit which is different.

Commits
-------

73fbd08 [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name

@fabpot fabpot referenced this pull request Nov 27, 2016

Merged

Release v3.2.0-RC2 #20649

This was referenced Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.