fix directory resource #2057

Merged
merged 1 commit into from Aug 30, 2011

Projects

None yet

3 participants

@rande
Contributor
rande commented Aug 30, 2011

fix regression introduces by 0eae562#diff-15

@fabpot fabpot added a commit that referenced this pull request Aug 30, 2011
@fabpot fabpot merged branch sonata-project/fix_directory_resource (PR #2057)
Commits
-------

74cbf96 fix directory resource

Discussion
----------

fix directory resource

fix regression introduces by 0eae562#diff-15
c8d6c60
@fabpot fabpot merged commit 74cbf96 into symfony:master Aug 30, 2011
@schmittjoh
Contributor

This change effectively adds all bundles as directory resources to the container which has pretty bad performance implications.

@fabpot fabpot added a commit that referenced this pull request Sep 16, 2011
@fabpot fabpot [Config] fixed FileResource usage of is_file (we must use file_exists…
… here as the resource can be a file or a directory, reverts #2057)
bede420
@fabpot
Member
fabpot commented Sep 16, 2011

@schmittjoh: I have reverted this change and made the proper fix in the FileResource class instead (see bede420).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment