Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Revert BC breaking change of Request::isMethodSafe() #20602

Merged
merged 1 commit into from Nov 24, 2016

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Nov 23, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? yes (reverting a previous BC break)
Deprecations? no
Tests pass? yes
Fixed tickets #20562
License MIT
Doc PR -

As spotted in #20562, we should not have broken a minor version. Instead, we should have deprecated the bad behavior. This is done in #20603.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-safe-bc branch from 43a480f to 0c3b7d7 Nov 23, 2016

@fabpot

This comment has been minimized.

Copy link
Member

commented Nov 24, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 0c3b7d7 into symfony:2.7 Nov 24, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Nov 24, 2016

bug #20602 [HttpKernel] Revert BC breaking change of Request::isMetho…
…dSafe() (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpKernel] Revert BC breaking change of Request::isMethodSafe()

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes (reverting a previous BC break)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20562
| License       | MIT
| Doc PR        | -

As spotted in #20562, we should not have broken a minor version. Instead, we should have deprecated the bad behavior. This is done in #20603.

Commits
-------

0c3b7d7 [HttpKernel] Revert BC breaking change of Request::isMethodSafe()

fabpot added a commit that referenced this pull request Nov 24, 2016

bug #20603 [HttpKernel] Deprecate checking for cacheable HTTP methods…
… in Request::isMethodSafe() (nicolas-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[HttpKernel] Deprecate checking for cacheable HTTP methods in Request::isMethodSafe()

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Late deprecation for 3.2, see #20602.

Commits
-------

34e7b95 [HttpKernel] Deprecate checking for cacheable HTTP methods in Request::isMethodSafe()

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-safe-bc branch Nov 24, 2016

@fabpot fabpot referenced this pull request Nov 27, 2016

Merged

Release v3.2.0-RC2 #20649

This was referenced Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.