Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fixed custom services definition BC break introduced in ec7e70fb… #20609

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@kiler129
Copy link
Contributor

commented Nov 23, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no, fixes previous BC
Deprecations? no
Tests pass? yes (verified on Win only)
Fixed tickets #20608
License MIT
Doc PR -
if ('Symfony\Component\DependencyInjection\Definition' !== get_class($definition)) {
throw new RuntimeException(sprintf('Constructing service "%s" from a %s is not supported at build time.', $id, get_class($definition)));
if ($definition instanceof DefinitionDecorator) {
throw new RuntimeException(sprintf('Constructing decorated service "%s" from a %s is not supported at build time.', $id, get_class($definition)));

This comment has been minimized.

Copy link
@stof

stof Nov 23, 2016

Member

this is not a decorated service. It is about using definition inheritance (yes, the name DefinitionDecorator is quite bad, but the service decoration feature was implemented years later)

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 23, 2016

Member

Constructing service "foo" from parent definition "bar" etc.

This comment has been minimized.

Copy link
@kiler129

kiler129 Nov 23, 2016

Author Contributor

Oh, I didn't knew that and just assumed that by name. I'm thinking how we can actually handle that without breaking custom definition classes.

Edit:
Actually if it's just that, instanceof checking for decorator should solve the problem, since for custom definition classes we'll never see DefinitionDecorator in inheritance chain while for decorators it will always be there.

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 23, 2016

Member

Can you update the message as suggested?

This comment has been minimized.

Copy link
@kiler129

kiler129 Nov 23, 2016

Author Contributor

Don't you think we should update this message to inform about service inheritance? For me "Constructing service "..." from a ... is not supported at build time." is too generic.

Maybe "Constructing service SERVICE_ID inherited from PARENT_ID is not supported at build time." will be a better fit?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 23, 2016

Member

That's why I added the "parent" word above, which is also the vocabulary used to declare such services

@kiler129

This comment has been minimized.

Copy link
Contributor Author

commented Nov 23, 2016

The failure on appveyor doesn't seems to be related to this PR change.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 24, 2016

Thank you @kiler129.

nicolas-grekas added a commit that referenced this pull request Nov 24, 2016

bug #20609 [DI] Fixed custom services definition BC break introduced …
…in ec7e70fb… (kiler129)

This PR was squashed before being merged into the 2.7 branch (closes #20609).

Discussion
----------

[DI] Fixed custom services definition BC break introduced in ec7e70fb…

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no, fixes previous BC
| Deprecations? | no
| Tests pass?   | yes (verified on Win only)
| Fixed tickets | #20608
| License       | MIT
| Doc PR        | -

Commits
-------

7a5e11e [DI] Fixed custom services definition BC break introduced in ec7e70fb…

@fabpot fabpot referenced this pull request Nov 27, 2016

Merged

Release v3.2.0-RC2 #20649

@kiler129 kiler129 deleted the kiler129:issue_20608 branch Nov 28, 2016

@kiler129

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2016

@nicolas-grekas: My pleasure ;)

This was referenced Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.