New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Resolve env params in debug:config command #20688

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 29, 2016

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20696
License MIT
Doc PR -

Displays e.g. url: '%env(DATABASE_URL)%'
instead of url: env_DATABASE_URL_b188317b1d181eca5f0be35aefdae9c4
when doing bin/console debug:config doctrine

@chalasr

This comment has been minimized.

Member

chalasr commented Nov 29, 2016

👍 from my side this fixes the main bug reported in #20684.

Status: reviewed

@javiereguiluz

This comment has been minimized.

Member

javiereguiluz commented Nov 30, 2016

👍

This solution worked for me too. Thanks Nicolas.

@stof

This comment has been minimized.

Member

stof commented Nov 30, 2016

👍

@chalasr

This comment has been minimized.

Member

chalasr commented Nov 30, 2016

@nicolas-grekas About #20696, I just checked this out after your last commit and the result is that running debug:container --parameter "env(database_url)" gives the parameter placeholder ("%env(database_url)%") and running debug:container --parameters gives the default parameter value.

It's quite better than the current output but as you can guess I expected to get the actual value of the parameter, which looks not possible actually. Does #20618 helps in that way?
Meantime, shouldn't the output be consistent for debug:config and debug:container with both options (maybe always dump the placeholder)?

Anyway, thank you for this.

@nicolas-grekas nicolas-grekas merged commit 695d100 into symfony:3.2 Dec 8, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 8, 2016

bug #20688 [FrameworkBundle] Resolve env params in debug:config comma…
…nd (nicolas-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[FrameworkBundle] Resolve env params in debug:config command

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20696
| License       | MIT
| Doc PR        | -

Displays e.g. `url: '%env(DATABASE_URL)%'`
instead of `url: env_DATABASE_URL_b188317b1d181eca5f0be35aefdae9c4`
when doing `bin/console debug:config doctrine`

Commits
-------

695d100 [FrameworkBundle] Resolve env params in debug:config command

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:debug-config-resolve branch Dec 8, 2016

@fabpot fabpot referenced this pull request Dec 13, 2016

Merged

Release v3.2.1 #20897

fabpot added a commit that referenced this pull request Dec 14, 2016

bug #20909 Fix misresolved parameters in debug:config on 3.2 (chalasr)
This PR was merged into the 3.2 branch.

Discussion
----------

Fix misresolved parameters in debug:config on 3.2

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This fixes parameters resolution (classic and env ones) in `debug:config`, again.
Merging #20714 broke the fix resolving env parameters made in #20688, and anyway it was mismerged (#20714 was not applied when using the `path` argument, my bad, I should have prevented it).

This adds a test which prevents regressions so I hope this is is the last PR on this subject.
The buggy output is unfortunately part of the last 3.2 release... It can easily be confirmed by running `debug:config doctrine` on a fresh symfony-demo project

Commits
-------

c88bc89 Fix misresolved parameters in debug:config on 3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment