New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle][Translator] Fix TranslationDataCollector should use cloneVar #20700

Merged
merged 1 commit into from Dec 2, 2016

Conversation

Projects
None yet
5 participants
@ogizanagi
Member

ogizanagi commented Nov 30, 2016

Q A
Branch? 3.2
Bug fix? yes?
New feature? no?
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Was missed in #19614 ?

Before

capture d ecran 2016-11-30 a 15 45 33

After

capture d ecran 2016-11-30 a 15 43 58

@ogizanagi ogizanagi changed the title from [WebProfiler][Translator] Fix TranslationDataCollector should use cloneVar to [WebProfilerBundle][Translator] Fix TranslationDataCollector should use cloneVar Nov 30, 2016

@chalasr

This comment has been minimized.

Member

chalasr commented Nov 30, 2016

Nice catch 👍

Status: reviewed

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 2, 2016

Thank you @ogizanagi.

@fabpot fabpot merged commit 07cdfd5 into symfony:3.2 Dec 2, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 2, 2016

bug #20700 [WebProfilerBundle][Translator] Fix TranslationDataCollect…
…or should use cloneVar (ogizanagi)

This PR was merged into the 3.2 branch.

Discussion
----------

[WebProfilerBundle][Translator] Fix TranslationDataCollector should use cloneVar

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes?
| New feature?  | no?
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Was missed in #19614 ?

### Before

![capture d ecran 2016-11-30 a 15 45 33](https://cloud.githubusercontent.com/assets/2211145/20756865/9a416934-b714-11e6-9cb5-890a6222b6fa.png)

### After

![capture d ecran 2016-11-30 a 15 43 58](https://cloud.githubusercontent.com/assets/2211145/20756877/9efaccae-b714-11e6-9523-b3f8f2e4bd8c.png)

Commits
-------

07cdfd5 [WebProfiler][Translator] Fix TranslationDataCollector should use cloneVar

@ogizanagi ogizanagi deleted the ogizanagi:fix/trans_collector_message_params_dump branch Dec 2, 2016

@PhilETaylor

This comment has been minimized.

Contributor

PhilETaylor commented Dec 2, 2016

This fixes my problem reported in the comments of #20698

@fabpot fabpot referenced this pull request Dec 13, 2016

Merged

Release v3.2.1 #20897

ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018

bug symfony#20700 [WebProfilerBundle][Translator] Fix TranslationData…
…Collector should use cloneVar (ogizanagi)

This PR was merged into the 3.2 branch.

Discussion
----------

[WebProfilerBundle][Translator] Fix TranslationDataCollector should use cloneVar

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes?
| New feature?  | no?
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Was missed in symfony#19614 ?

### Before

![capture d ecran 2016-11-30 a 15 45 33](https://cloud.githubusercontent.com/assets/2211145/20756865/9a416934-b714-11e6-9cb5-890a6222b6fa.png)

### After

![capture d ecran 2016-11-30 a 15 43 58](https://cloud.githubusercontent.com/assets/2211145/20756877/9efaccae-b714-11e6-9523-b3f8f2e4bd8c.png)

Commits
-------

07cdfd5 [WebProfiler][Translator] Fix TranslationDataCollector should use cloneVar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment