New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] add class name to the cache key #20745

Closed
wants to merge 3 commits into
base: 3.1
from

Conversation

Projects
None yet
5 participants
@Simperfit
Contributor

Simperfit commented Dec 3, 2016

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20685
License MIT
Doc PR

Adding the class name to the cache key to avoid collision

@Simperfit Simperfit changed the title from fix - #20685: add class name to the cache key to [WIP] fix - #20685: add class name to the cache key Dec 3, 2016

@Simperfit Simperfit changed the title from [WIP] fix - #20685: add class name to the cache key to fix - #20685: add class name to the cache key Dec 4, 2016

@Simperfit Simperfit changed the title from fix - #20685: add class name to the cache key to [Validator] fix - #20685: add class name to the cache key Dec 5, 2016

@dunglas

Can you also add a test with a relation between ChildA and ChilB?

{
/**
* @Assert\Valid
* @Assert\NotBlank

This comment has been minimized.

@dunglas

dunglas Dec 6, 2016

Member

You should use another assertion to be sure that there is no collision.

@dunglas

dunglas approved these changes Dec 8, 2016

@dunglas

This comment has been minimized.

Member

dunglas commented Dec 8, 2016

👍

protected $lastName;
public $reference;
public $reference2;
private $internal;
public $data = 'Overridden data';
public $initialized = false;

This comment has been minimized.

@stof

stof Dec 8, 2016

Member

this line should be kept

This comment has been minimized.

@Simperfit

Simperfit Dec 8, 2016

Contributor

👍

@nicolas-grekas nicolas-grekas changed the title from [Validator] fix - #20685: add class name to the cache key to [Validator] add class name to the cache key Dec 8, 2016

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 8, 2016

Thank you @Simperfit.

nicolas-grekas added a commit that referenced this pull request Dec 8, 2016

bug #20745 [Validator] add class name to the cache key (Simperfit)
This PR was squashed before being merged into the 3.1 branch (closes #20745).

Discussion
----------

[Validator] add class name to the cache key

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |  #20685
| License       | MIT
| Doc PR        |

Adding the class name to the cache key to avoid collision

Commits
-------

1681fc9 [Validator] add class name to the cache key

@Simperfit Simperfit deleted the Simperfit:fix/20685 branch Dec 8, 2016

This was referenced Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment