New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Fix FormDataCollector #20762

Merged
merged 2 commits into from Dec 6, 2016

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 5, 2016

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20698
License MIT
Doc PR -

Alternative to #20707

@stof

This comment has been minimized.

Member

stof commented Dec 5, 2016

Can you add test covering the bug to prevent regressions ?

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 5, 2016

No, I can't... This code is a maze...

@stof

This comment has been minimized.

Member

stof commented Dec 5, 2016

Well, you said you had a reproducer. Couldn't it be used as a test ?

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 5, 2016

It's a functional test with master + sub requests + profiler enabled. ie. a heavy stack...

@Padam87 Padam87 referenced this pull request Dec 5, 2016

Closed

Fixed form data collector #20707

@Padam87

This comment has been minimized.

Contributor

Padam87 commented Dec 5, 2016

I can confirm that the patch works.

Padam87 added a commit to Padam87/symfony that referenced this pull request Dec 5, 2016

@Padam87

This comment has been minimized.

Contributor

Padam87 commented Dec 5, 2016

I've added a failing test, which is fixed by this patch

@stof

This comment has been minimized.

Member

stof commented Dec 6, 2016

👍

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 6, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 50400c4 into symfony:3.2 Dec 6, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 6, 2016

bug #20762 [Form] Fix FormDataCollector (nicolas-grekas, Padam87)
This PR was merged into the 3.2 branch.

Discussion
----------

[Form] Fix FormDataCollector

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20698
| License       | MIT
| Doc PR        | -

Alternative to #20707

Commits
-------

50400c4 [Form] Add failing test for data collector bug
164a20c [Form] Fix FormDataCollector

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-form-data-collector branch Dec 9, 2016

@fabpot fabpot referenced this pull request Dec 13, 2016

Merged

Release v3.2.1 #20897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment