New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Removed kernel.debug from the cache pool namespace seed #20816

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
4 participants
@Sander-Toonen
Contributor

Sander-Toonen commented Dec 7, 2016

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20780
License MIT
Doc PR

@nicolas-grekas nicolas-grekas added this to the 3.1 milestone Dec 7, 2016

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 7, 2016

The arguments presented in #20780 are sensible to me
👍

@Sander-Toonen

This comment has been minimized.

Contributor

Sander-Toonen commented Dec 7, 2016

Ok, I'll create a similar pr for the DoctrineCacheBundle then.

@xabbuh

This comment has been minimized.

Member

xabbuh commented Dec 7, 2016

👍

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 8, 2016

Thank you @Sander-Toonen.

@fabpot fabpot merged commit 8e1dac5 into symfony:3.1 Dec 8, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 8, 2016

bug #20816 [FrameworkBundle] Removed kernel.debug from the cache pool…
… namespace seed (Sander Toonen)

This PR was merged into the 3.1 branch.

Discussion
----------

[FrameworkBundle] Removed kernel.debug from the cache pool namespace seed

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20780
| License       | MIT
| Doc PR        |

Commits
-------

8e1dac5 [FrameworkBundle] Removed the kernel.debug parameter from the cache pool namespace seed

@Sander-Toonen Sander-Toonen deleted the Sander-Toonen:ticket_20780 branch Dec 8, 2016

This was referenced Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment