New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twig] Fix deprecations with Twig 1.29 #20831

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 8, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20829
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 8, 2016

@stof

This comment has been minimized.

Member

stof commented Dec 8, 2016

@nicolas-grekas can you also check deprecations in the profiler ? #20829 makes me think we have some there too

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 8, 2016

@stof updated

@nicolas-grekas nicolas-grekas merged commit 9218cac into symfony:2.7 Dec 8, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 8, 2016

bug #20831 [Twig] Fix deprecations with Twig 1.29 (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Twig] Fix deprecations with Twig 1.29

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20829
| License       | MIT
| Doc PR        | -

Commits
-------

9218cac [Twig] Fix deprecations with Twig 1.29

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:twig-129 branch Dec 8, 2016

nicolas-grekas added a commit that referenced this pull request Jan 10, 2017

bug #21179 [TwigBundle] Fixing regression in TwigEngine exception han…
…dling (Bertalan Attila)

This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBundle] Fixing regression in TwigEngine exception handling

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21176
| License       | MIT

Fixing regression after #20831 in TwigEngine exception handling.

Commits
-------

390cb33 Fixing regression in TwigEngine exception handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment