New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] do not trigger deprecations for valid YAML #20855

Merged
merged 1 commit into from Dec 13, 2016

Conversation

Projects
None yet
5 participants
@xabbuh
Member

xabbuh commented Dec 10, 2016

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19874
License MIT
Doc PR
if (!isset($mapping[$i + 1]) || ' ' !== $mapping[$i + 1]) {
@trigger_error('Omitting the space after the colon that follows a mapping key definition is deprecated since version 3.2 and will throw a ParseException in 4.0.', E_USER_DEPRECATED);
if (!isset($mapping[$i + 1]) || !in_array($mapping[$i + 1], array(' ', '[', ']', '{', '}'), true)) {
@trigger_error('Using a colon that is not followed by an indication character (i.e. " ", ",", "[", "]", "{", "}" is deprecated since version 3.2 and will throw a ParseException in 4.0.', E_USER_DEPRECATED);

This comment has been minimized.

@GuilhemN

GuilhemN Dec 10, 2016

Contributor

will be considered as part of the value in 4.0?

This comment has been minimized.

@xabbuh

xabbuh Dec 12, 2016

Member

That would be misleading as the current outcome is depending on the actual YAML input. You may get an exception, but the colon might also be treated as part of the mapping key.

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 13, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit 1436349 into symfony:3.2 Dec 13, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 13, 2016

bug #20855 [Yaml] do not trigger deprecations for valid YAML (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] do not trigger deprecations for valid YAML

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19874
| License       | MIT
| Doc PR        |

Commits
-------

1436349 do not trigger deprecations for valid YAML

@xabbuh xabbuh deleted the xabbuh:issue-19874-deprecation-refinement branch Dec 13, 2016

@fabpot fabpot referenced this pull request Dec 13, 2016

Merged

Release v3.2.1 #20897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment